[PATCH] D33841: [clang-tidy] redundant keyword check

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: docs/clang-tidy/checks/readability-redundant-extern.rst:4
+readability-redundant-extern
+=============================
+
----------------
The underlining here is too long.


================
Comment at: docs/clang-tidy/checks/readability-redundant-extern.rst:14
+  
\ No newline at end of file

----------------
Please add the newline to the end of the file.


================
Comment at: test/clang-tidy/readability-redundant-extern.cpp:2
+// RUN: %check_clang_tidy %s readability-redundant-extern %t
+
+extern int f();
----------------
This is missing some other negative tests, like a file-scope:
```
void file_scope();
```
an especially interesting test would be:
```
void another_file_scope(int _extern);
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D33841/new/

https://reviews.llvm.org/D33841