r353592 - [analyzer] Add a comment that FunctionCodeRegions may also need canonicalization

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 8 17:00:32 PST 2019


Author: dergachev
Date: Fri Feb  8 17:00:32 2019
New Revision: 353592

URL: http://llvm.org/viewvc/llvm-project?rev=353592&view=rev
Log:
[analyzer] Add a comment that FunctionCodeRegions may also need canonicalization

Modified:
    cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp

Modified: cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp?rev=353592&r1=353591&r2=353592&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp Fri Feb  8 17:00:32 2019
@@ -1009,6 +1009,7 @@ MemRegionManager::getElementRegion(QualT
 
 const FunctionCodeRegion *
 MemRegionManager::getFunctionCodeRegion(const NamedDecl *FD) {
+  // To think: should we canonicalize the declaration here?
   return getSubRegion<FunctionCodeRegion>(FD, getCodeRegion());
 }
 




More information about the cfe-commits mailing list