[PATCH] D57986: [ProfileData] Remove non-determinism: Change DenseMap to MapVector
Mandeep Singh Grang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 8 16:36:15 PST 2019
mgrang added a comment.
tools/llvm-profdata/instr-remap.test is failing in the reverse iteration bot. See http://lab.llvm.org:8011/builders/reverse-iteration/builds/10546/steps/check_all/logs/stdio.
This is because FunctionData is iterated in InstrProfWriter to output function counts, etc. But for two functions with the same name the iteration order is not defined if we use a DenseMap. Changing this to MapVector resolves this.
Note: We can also sort FunctionData before iteration to fix this issue. But that would mean we would need to sort every time we iterate in order to print. Using a MapVector instead is a better option IMO.
CHANGES SINCE LAST ACTION
More information about the cfe-commits