[PATCH] D57874: [WebAssembly] Make thread-related options consistent

Heejin Ahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 8 16:07:06 PST 2019


aheejin added a comment.

In D57874#1389981 <https://reviews.llvm.org/D57874#1389981>, @sunfish wrote:

> > - `-matomics` means `-mthread-model posix`
>
> The others sound reasonable, though this one seems a little surprising -- a user might have -matomics enabled because they're targeting a VM that has atomics, but still not want to use -mthread-model posix because their code doesn't actually using threads.


As @sbc said, `-mthread-model` is only used in ARM and wasm backend to determine whether to lower away atomic instructions or not. So that the user gave `-matomics` means the VM can support atomic instructions, so even if we are not actually using threads, it's fine because the VM can handle them.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57874/new/

https://reviews.llvm.org/D57874





More information about the cfe-commits mailing list