[PATCH] D57930: [Driver] Verify GCCInstallation is valid

Stephen Hines via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 7 17:09:39 PST 2019


srhines added a comment.

Would it be reasonable to have a test for this with perhaps an invalid GCC installation? There is some mock GCC/sysroot testing in https://github.com/llvm/llvm-project/blob/master/clang/test/Driver/android-gcc-toolchain.c and https://github.com/llvm/llvm-project/blob/master/clang/test/Driver/android-ndk-standalone.cpp. I am not sure that it will be easy to trip this same bug that way, but I think it is possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57930/new/

https://reviews.llvm.org/D57930





More information about the cfe-commits mailing list