[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 7 09:02:25 PST 2019


rjmccall added a comment.

In D57768#1386862 <https://reviews.llvm.org/D57768#1386862>, @Anastasia wrote:

> - SYCL seem to require adding tight dependencies from the standard libraries into the compiler because many language features are hidden behind library classes. This is not common for Clang. We had a discussion about this issue during the implementation of OpenCL C++ and it was decided not to go this route for upstream Clang. Can you explain your current approach to implement this? I think @rjmccall  or @rsmith might need to be involved in this.


I'd like to know more about this, but I'll point out that this isn't unprecedented:

- C compilers have hard-coded knowledge about `va_list`.
- C++ compilers have hard-coded knowledge about `std::type_info` and `std::initializer_list` (and possibly others I've forgotten).

Whether that's the right direction for SYCL, though, I can't say until I understand more about what dependencies are being proposed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57768/new/

https://reviews.llvm.org/D57768





More information about the cfe-commits mailing list