[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 6 11:55:31 PST 2019
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Great stuff! Sorry for the delay here.
Comment at: clangd/IncludeFixer.h:59
+ SourceLocation Loc; // Start location of the unresolved name.
+ // Callback to get possible scopes of the unresolved name. `Sema` must be
+ // alive when this is called.
nit: this isn't really a callback, I think.
Just "Lazily get the possible scopes of the unresolved name"?
Comment at: clangd/IncludeFixer.h:64
+ /// Records the last unresolved name (i.e. typo) seen by Sema.
+ class UnresolvedNameRecorder;
"i.e. typo" is confusing here, as these aren't actually typos
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
More information about the cfe-commits