[PATCH] D57739: [clangd] Format tweak's replacements.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 6 05:37:32 PST 2019


hokein added inline comments.


================
Comment at: clangd/refactor/Tweak.h:56
+    /// The style to format generated changes.
+    format::FormatStyle Style;
   };
----------------
ilya-biryukov wrote:
> NIT: Maybe make this a second argument of `apply`?
> This would convey the idea that `execute()` should not do formatting on its own.
SG, this also makes the `format` intention of `apply` more explicitly.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57739/new/

https://reviews.llvm.org/D57739





More information about the cfe-commits mailing list