[PATCH] D57508: [clangd] Enable include insertion for dynamic index

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 4 07:03:51 PST 2019


ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

lgtm.

Note that this will enable include insertions for everyone (even without index switched on). Not sure if we should provide options.



================
Comment at: clangd/ClangdServer.cpp:16
 #include "Trace.h"
+#include "XRefs.h"
+#include "index/CanonicalIncludes.h"
----------------
nit: is this used?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57508/new/

https://reviews.llvm.org/D57508





More information about the cfe-commits mailing list