[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno added a comment.

In D57649#1382477 <https://reviews.llvm.org/D57649#1382477>, @aaron.ballman wrote:

> In D57649#1382470 <https://reviews.llvm.org/D57649#1382470>, @riccibruno wrote:
>
> > Though it is a subjective distinction and in the end if someone need a flag it is going to be added I guess.
>
>
> That's the crux of how we've decided what information to expose in the past. Some folks will expose the information when adding it to an AST node, but not always. More often what happens is that someone finds they need that information to help make an AST dump more readable, then the information gets exposed at that point because there's a use case for it.


Which is exactly why I added this flag. From what I understand the AST dump is mostly a tool used by people hacking on clang, and so this make sense.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57649/new/

https://reviews.llvm.org/D57649