[PATCH] D57509: [clangd] Append "(fix available)" to diagnostic message when fixes are present.

[Eric Liu via Phabricator via cfe-commits]

ioeric added a subscriber: hokein.
ioeric added a comment.

In D57509#1378978 <https://reviews.llvm.org/D57509#1378978>, @ilya-biryukov wrote:

> In D57509#1378943 <https://reviews.llvm.org/D57509#1378943>, @ioeric wrote:
>
> > Yes, but a new option seems a bit of an overkill here.  The text is appended and doesn't seem to affect the readability of original diagnostic message much (IMO).  Could you elaborate why this is undesirable in vscode for you?
>
>
> It's basically just noise, as VSCode shows the bulb icons whenever you hover over the diagnostics with errors.
>  Having a standard suffix in half of the diagnostics seems undesirable.


I don't think it's pure noise. Vscode displays diagnostics in the "PROBLEMS" tab. A suffix allows you to tell whether fixes are available without hovering on the errors.

That said, I'm not opposed to a config option. Would love to hear others' thoughts tho. @sammccall @hokein @kadircet


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57509/new/

https://reviews.llvm.org/D57509