[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

Stefan Gränitz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 31 10:11:10 PST 2019


sgraenitz added a comment.

In case compiler-rt abandons `llvm-config` in favor of `find_package(LLVM)` one day, we could drop the `COMPILER_RT_HAS_LLVMTESTINGSUPPORT` logic here and use imported target properties instead. It seems a cleaner solution to me and avoids issues like D57521 <https://reviews.llvm.org/D57521>.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55891/new/

https://reviews.llvm.org/D55891





More information about the cfe-commits mailing list