[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

Bevin Hansson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 25 03:41:34 PST 2019


ebevhan created this revision.
ebevhan added reviewers: leonardchan, rjmccall.
Herald added a subscriber: cfe-commits.
ebevhan marked an inline comment as done.
ebevhan added inline comments.


================
Comment at: include/clang/Serialization/ASTBitCodes.h:1637
+      /// A FixedPointLiteral record.
+      EXPR_FIXEDPOINT_LITERAL,
+
----------------
I'm unsure if this is the right location for a new code. This will bump down all the other codes below this and cause any older file to not be read correctly.

Should the file format version number be bumped up?


This patch adds the EXPR_FIXEDPOINT_LITERAL AST
code to serialize FixedPointLiterals. They were previously
being serialized with the code for integer literals, which
doesn't work properly.


Repository:
  rC Clang

https://reviews.llvm.org/D57226

Files:
  include/clang/AST/Expr.h
  include/clang/Serialization/ASTBitCodes.h
  lib/AST/Expr.cpp
  lib/Serialization/ASTReaderStmt.cpp
  lib/Serialization/ASTWriter.cpp
  lib/Serialization/ASTWriterStmt.cpp
  test/PCH/fixed-point-literal.c
  test/PCH/fixed-point-literal.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57226.183511.patch
Type: text/x-patch
Size: 4942 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190125/94f73d33/attachment.bin>


More information about the cfe-commits mailing list