[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno added inline comments.


================
Comment at: include/clang/AST/Expr.h:5020
   Stmt **SubExprs;
   unsigned NumAssocs, ResultIndex;
   SourceLocation GenericLoc, DefaultLoc, RParenLoc;
----------------
I know that this is not part of this patch, but these arrays are begging
to be tail-allocated if you want to have a go at it.


================
Comment at: include/clang/AST/Expr.h:5047
+    bool Selected;
+
+  public:
----------------
What about some comments ? I can guess but it is better to have
too much doc than not enough imho.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56959/new/

https://reviews.llvm.org/D56959