[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 18 06:01:21 PST 2019


JonasToth added a comment.

In D54141#1362924 <https://reviews.llvm.org/D54141#1362924>, @MyDeveloperDay wrote:

> > LLVM is very chatty as well, I don't consider LLVM to be a bad code-base. Take readability-braces-around-statements for example.
>
> Do we need a llvm-elide-braces-for-small-statements?
>
> This would make a great pre-review check


IMHO wouldn't hurt. It could even be a readability, one. But we need general thought on how to deal with conflicting checks, in this case especially.
Maybe we could extend the `readability-braces-around-statements` check with its `AntiCheck` and make it configurable. Therefore collision cant be emitted?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54141/new/

https://reviews.llvm.org/D54141





More information about the cfe-commits mailing list