[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

Simon Atanasyan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 18 05:11:27 PST 2019


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lib/Driver/ToolChains/Clang.cpp:1720
+      CmdArgs.push_back("-mllvm");
+      CmdArgs.push_back(Args.MakeArgString("-mips-jalr-reloc=0"));
+    }
----------------
It's not necessary to call the `MakeArgString` here. You can write just `CmdArgs.push_back("-mips-jalr-reloc=0");`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56878/new/

https://reviews.llvm.org/D56878





More information about the cfe-commits mailing list