[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 17 08:18:10 PST 2019


ymandel marked 2 inline comments as done.
ymandel added inline comments.


================
Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:475
+  auto MatchesType = cxxMemberCallExpr(on(hasType(cxxRecordDecl(hasName("X")))));
+  EXPECT_TRUE(matches(
+      R"cc(
----------------
steveire wrote:
> Could you add a test which uses the same c++ snippet as this, but with a matcher using `hasName("Y")`?
Good suggestion -- this caught a mistake in the comments. I'll update the other diff to reflect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56850/new/

https://reviews.llvm.org/D56850





More information about the cfe-commits mailing list