[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 16 16:12:15 PST 2019


erik.pilkington updated this revision to Diff 182182.
erik.pilkington added a comment.

Address review comments: move the check to a function, and call it when emitting the ivar offset instead of when we emit the global. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56802/new/

https://reviews.llvm.org/D56802

Files:
  clang/lib/CodeGen/CGObjCMac.cpp
  clang/test/CodeGenObjC/constant-non-fragile-ivar-offset.m
  clang/test/CodeGenObjC/optimize-ivar-offset-load.m
  clang/test/CodeGenObjC/reorder-synthesized-ivars.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56802.182182.patch
Type: text/x-patch
Size: 7178 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190117/b1d5732f/attachment.bin>


More information about the cfe-commits mailing list