[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: lib/Parse/ParseDecl.cpp:6170
+          }
+        }
+      }
----------------
Does this not need to diagnose redundant qualifiers?  Why is this path required in addition to the path in SemaType, anyway?


================
Comment at: lib/Sema/SemaType.cpp:3930
+      return true;
+    } else
+      // Emit a warning if they are identical; it's likely unintended.
----------------
I'd just drop this `else`, but if you want to include it, please use braces for consistency with the rest of the `if`-chain.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55850/new/

https://reviews.llvm.org/D55850