[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 16 11:32:45 PST 2019


rjmccall added a comment.

I don't pay attention to "ready to land" because I assume that you're verifying that your patch actually works as promised in practice, at least as far as the tests are concerned (and presumably my review catches deeper issues). If there are substantial changes that landed after my review, then I need to re-review; otherwise, you should feel free to commit with that kind of provisional LGTM when you've satisfied the provisions.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55844/new/

https://reviews.llvm.org/D55844





More information about the cfe-commits mailing list