[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 16 11:09:20 PST 2019


rjmccall added a comment.

Thanks, LGTM.

Well, actually, could you improve the test case to verify that the right overload is called?  This should be easy because C++ type-checking is bottom-up: just make the functions return something distinguishable, e.g. `struct`s that declare different members.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56735/new/

https://reviews.llvm.org/D56735





More information about the cfe-commits mailing list