[PATCH] D56599: [Support] Remove error return value from one overload of fs::make_absolute

Pavel Labath via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 16 02:00:13 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rC351317: [Support] Remove error return value from one overload of fs::make_absolute (authored by labath, committed by ).
Herald added a subscriber: cfe-commits.

Changed prior to commit:
  https://reviews.llvm.org/D56599?vs=181273&id=181997#toc

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56599/new/

https://reviews.llvm.org/D56599

Files:
  lib/Lex/HeaderSearch.cpp


Index: lib/Lex/HeaderSearch.cpp
===================================================================
--- lib/Lex/HeaderSearch.cpp
+++ lib/Lex/HeaderSearch.cpp
@@ -1678,9 +1678,8 @@
     StringRef Dir = SearchDirs[I].getDir()->getName();
     llvm::SmallString<32> DirPath(Dir.begin(), Dir.end());
     if (!WorkingDir.empty() && !path::is_absolute(Dir)) {
-      auto err = fs::make_absolute(WorkingDir, DirPath);
-      if (!err)
-        path::remove_dots(DirPath, /*remove_dot_dot=*/true);
+      fs::make_absolute(WorkingDir, DirPath);
+      path::remove_dots(DirPath, /*remove_dot_dot=*/true);
       Dir = DirPath;
     }
     for (auto NI = path::begin(File), NE = path::end(File),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56599.181997.patch
Type: text/x-patch
Size: 689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190116/2e14859e/attachment-0001.bin>


More information about the cfe-commits mailing list