r344241 - [tests] Include Python binding tests in CMake rules

[Michał Górny via cfe-commits]

On Tue, 2019-01-15 at 13:10 -0500, Nico Weber wrote:
> The tests probably shouldn't run when LLVM_ENABLE_PIC=OFF is set, since
> they all fail there (due to lib/libclang.so not existing).

Hmm, maybe we could make them conditional to the existence
of libclang.so target?  Would that work for you?

> 
> On Thu, Oct 11, 2018 at 7:59 AM Michal Gorny via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
> 
> > Author: mgorny
> > Date: Thu Oct 11 04:58:14 2018
> > New Revision: 344241
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=344241&view=rev
> > Log:
> > [tests] Include Python binding tests in CMake rules
> > 
> > Add a new CMake rule check-clang-python to run the Python bindings'
> > test suite, and include it in check-all.
> > 
> > Differential Revision: https://reviews.llvm.org/D52840
> > 
> > Added:
> >     cfe/trunk/bindings/python/tests/CMakeLists.txt
> > Modified:
> >     cfe/trunk/CMakeLists.txt
> > 
> > Modified: cfe/trunk/CMakeLists.txt
> > URL:
> > http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=344241&r1=344240&r2=344241&view=diff
> > 
> > ==============================================================================
> > --- cfe/trunk/CMakeLists.txt (original)
> > +++ cfe/trunk/CMakeLists.txt Thu Oct 11 04:58:14 2018
> > @@ -502,6 +502,7 @@ if( CLANG_INCLUDE_TESTS )
> >        )
> >    endif()
> >    add_subdirectory(utils/perf-training)
> > +  add_subdirectory(bindings/python/tests)
> >  endif()
> > 
> >  option(CLANG_INCLUDE_DOCS "Generate build targets for the Clang docs."
> > 
> > Added: cfe/trunk/bindings/python/tests/CMakeLists.txt
> > URL:
> > http://llvm.org/viewvc/llvm-project/cfe/trunk/bindings/python/tests/CMakeLists.txt?rev=344241&view=auto
> > 
> > ==============================================================================
> > --- cfe/trunk/bindings/python/tests/CMakeLists.txt (added)
> > +++ cfe/trunk/bindings/python/tests/CMakeLists.txt Thu Oct 11 04:58:14 2018
> > @@ -0,0 +1,7 @@
> > +# Test target to run Python test suite from main build.
> > +
> > +add_custom_target(check-clang-python
> > +       COMMAND CLANG_LIBRARY_PATH=$<TARGET_FILE_DIR:libclang>
> > ${PYTHON_EXECUTABLE} -m unittest discover
> > +       DEPENDS libclang
> > +       WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/..)
> > +add_dependencies(check-all check-clang-python)
> > 
> > 
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> > 

-- 
Best regards,
Michał Górny
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190115/a5de8f24/attachment-0001.sig>