[PATCH] D56555: Add Attribute to define nonlazy objc classes

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 14 09:21:53 PST 2019


aaron.ballman added a comment.

It's still missing the tests in SemaObjC -- you can use clang\test\SemaObjC\attr-root-class.m as an example of what I'm talking about.



================
Comment at: clang/include/clang/Basic/Attr.td:1697
+  let LangOpts = [ObjC]
+  let Documentation = [Undocumented];
+}
----------------
You need to hook this up to `ObjCNonLazyClassDocs`.


================
Comment at: clang/test/CodeGenObjC/non-lazy-classes.m:39-40
+
+    @implementation D
+    @end
----------------
The formatting is incorrect here.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56555/new/

https://reviews.llvm.org/D56555





More information about the cfe-commits mailing list