[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

Mateusz Maćkowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 13 08:36:23 PST 2019


m4tx added a comment.

I've added the implicit access specifier check and run it on some bigger codebases. My findings are as below:

- Dolphin: 6 //triggers across// 856 //record types//
- OpenCV: 31 //triggers across// 3370 //record types//
- Inkscape: 39 //triggers across// 846 //record types//
- LLVM (Core + Clang + Clang Tools Extra): 128 //triggers across// 9214 //record types//
- Blender: 948 //triggers across// 6264 //record types//

Since the check was triggered in every big project I've tested, I've decided to add an option (disabled by default) to enable the implicit access specifier check. It is included in my latest Diff, along with the rename to `readability-redundant-access-specifiers`.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55793/new/

https://reviews.llvm.org/D55793





More information about the cfe-commits mailing list