r350984 - NFC: Port loop to cxx_range_for

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 11 18:05:17 PST 2019


On Fri, Jan 11, 2019 at 7:46 PM Stephen Kelly via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
> Author: steveire
> Date: Fri Jan 11 16:42:59 2019
> New Revision: 350984
>
> URL: http://llvm.org/viewvc/llvm-project?rev=350984&view=rev
> Log:
> NFC: Port loop to cxx_range_for

Thanks for the cleanup!

>
> Modified:
>     cfe/trunk/lib/AST/ASTDumper.cpp
>
> Modified: cfe/trunk/lib/AST/ASTDumper.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTDumper.cpp?rev=350984&r1=350983&r2=350984&view=diff
> ==============================================================================
> --- cfe/trunk/lib/AST/ASTDumper.cpp (original)
> +++ cfe/trunk/lib/AST/ASTDumper.cpp Fri Jan 11 16:42:59 2019
> @@ -709,9 +709,8 @@ void ASTDumper::dumpTemplateArgument(con
>        break;
>      case TemplateArgument::Pack:
>        OS << " pack";
> -      for (TemplateArgument::pack_iterator I = A.pack_begin(), E = A.pack_end();
> -           I != E; ++I)
> -        dumpTemplateArgument(*I);
> +      for (const auto& TArg : A.pack_elements())

The formatting above is incorrect -- clang-format helps to avoid that.

~Aaron

> +        dumpTemplateArgument(TArg);
>        break;
>      }
>    });
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list