[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

Mandeep Singh Grang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 10 12:31:05 PST 2019


mgrang added a comment.

In D53541#1282900 <https://reviews.llvm.org/D53541#1282900>, @rnk wrote:

> In D53541#1282764 <https://reviews.llvm.org/D53541#1282764>, @mgrang wrote:
>
> > Updated the patch with the following changes:
> >
> > 1. Emit llvm.x86.seh.recoverfp only for non-aarch64 targets. For aarch64 windows, the parent fp is always passed in x1. So we don't need a separate instrinsic to recover the fp.
>
>
> What about the three stack pointer case of stack realignment plus a dynamic alloca? Typically this is the case where recoverfp is necessary.


@rnk Sorry, I missed your comment earlier. I am not sure what scenario the three stack pointer case is. Could you please give me a test case for it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53541/new/

https://reviews.llvm.org/D53541





More information about the cfe-commits mailing list