[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

Kamil Rytarowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 10 12:14:58 PST 2019


krytarowski added inline comments.


================
Comment at: ELF/Writer.cpp:1980
+  if (!Config->ZNognustack) {
+    // PT_GNU_STACK is a special section to tell the loader to make the
+    // pages for the stack non-executable. If you really want an executable
----------------
section -> segment?


================
Comment at: docs/ld.lld.1:515
+.Dv PT_GNU_STACK
+segment.
 .It Cm norelro
----------------
mgorny wrote:
> krytarowski wrote:
> > section?
> I think 'segment' is actually the correct term here.
I see, probably right.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56554/new/

https://reviews.llvm.org/D56554





More information about the cfe-commits mailing list