[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

Thu Jan 10 10:06:48 PST 2019

sammccall added a reviewer: ilya-biryukov.
sammccall added a comment.

In D56444#1351714 <https://reviews.llvm.org/D56444#1351714>, @JonasToth wrote:

> @sammccall I (hopefully) fixed the type-issue in my test-cases. They nevertheless fail both on me, on latest llvm+clang+your patch. Clang-tidy still the same, so maybe there is a difference in our builds?
>  Do you build with assertions on?
>  I work on linux, ubuntu 18.04, building with clang-6.0, maybe there is a difference?

Your tests indeed fail (I was rebuilding `AnalysisTests` instead of `ClangAnalysisTests`, oops!).
The `// namespace std` comments out the rest of the test, because the test contains no newlines. Try using raw strings instead :-)
After removing the comments, the tests pass.

In D56444#1351257 <https://reviews.llvm.org/D56444#1351257>, @steveire wrote:

> I believe I have a solution to this, but this is not the place to discuss it. We can discuss it when I propose that patch :). I'll be sure to add you to the review.

Understood, looking forward to hearing it! It would certainly be nice if there was a way to run matchers over a simpler/more consistent AST when appropriate.

@aaron.ballman @JonasToth I think this is ready for review again :-)

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56444/new/

https://reviews.llvm.org/D56444