[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 10 07:55:48 PST 2019


ilya-biryukov added a comment.

Only one important comment about bringing back the comment.



================
Comment at: clangd/index/Background.cpp:224
+        auto NeedsReIndexing = loadShards(std::move(ChangedFiles));
+        // Run indexing for files that needs to be updated.
+        std::shuffle(NeedsReIndexing.begin(), NeedsReIndexing.end(),
----------------
a typo: s/that needs/that need/


================
Comment at: clangd/index/Background.cpp:344
+      DigestIt.first->second = Hash;
+      IndexedSymbols.update(Path, std::move(SS), std::move(RS));
+    }
----------------
Let's bring back the comment about rewriting the newer version.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55224/new/

https://reviews.llvm.org/D55224





More information about the cfe-commits mailing list