[PATCH] D55492: Implement Attr dumping in terms of visitors

[Stephen Kelly via Phabricator via cfe-commits]

steveire marked an inline comment as done.
steveire added inline comments.


================
Comment at: utils/TableGen/ClangAttrEmitter.cpp:3726
+    functionContent = SS.str();
+    if (SS.tell()) {
+      OS << "  void Visit" << R.getName() << "Attr(const " << R.getName()
----------------
aaron.ballman wrote:
> Wouldn't this be `!FunctionContent.empty()`?
I would have thought so, but apparently that's not how `raw_string_ostream` works. I get an empty file from this if I do that.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55492/new/

https://reviews.llvm.org/D55492