[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

[Evgenii Stepanov via Phabricator via cfe-commits]

eugenis added a comment.

In D56109#1341967 <https://reviews.llvm.org/D56109#1341967>, @mgorny wrote:

> We've been discussing this, and I think we're doing this the wrong way. Could you help me a little understand this?
>
> In particular, what is the purpose of unpoisoning file? Is it in order to account for stdio functions being implemented inline or as macros, and therefore user code accessing internal `FILE` members? Or is there some other use case for this?
>
> If only the former, then I think there is no purpose in definining `__sanitizer_FILE` on NetBSD, as we support only reentrant interfaces which are all implemented as libc routine calls.


Yes, AFAIR unpoisoning of struct FILE was done specifically to support inlined and _unlocked stdio functions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56109/new/

https://reviews.llvm.org/D56109