[PATCH] D56442: [clangd] Fix a crash when reading an empty index file.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 8 07:15:24 PST 2019


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for fixing this.

A few questions for the long-term:

- Should we consider removing the YAML support altogether?
- If we want to keep, are there non-private APIs that we could use? (I assume we need them to avoid keeping the whole parsed YAML tree in memory, right?)


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56442/new/

https://reviews.llvm.org/D56442





More information about the cfe-commits mailing list