[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 7 23:15:16 PST 2019


rjmccall added inline comments.


================
Comment at: lib/Sema/SemaLambda.cpp:793
+  else
+    Args = Init;
+
----------------
Please maintain the original order here, even though I suspect it doesn't matter: if this is direct-initialization, use the arguments, otherwise use either `DeducedAutoInit` or `Init`.  Although really, consider just reassigning `Init` immediately after the `deduceVarType...` call.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55662/new/

https://reviews.llvm.org/D55662





More information about the cfe-commits mailing list