[PATCH] D56415: NFC: Port QueryParser to StringRef

Kristina Brooks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 7 18:05:09 PST 2019


kristina added a reviewer: kristina.
kristina added a comment.

LGTM aside from one comment.



================
Comment at: clang-query/QueryParser.cpp:36
+  if (Line.front() == '#') {
+    Line = {};
     return StringRef();
----------------
I don't think this is the best way of handling it, in fact I'm pretty certain you're leaking memory here.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56415/new/

https://reviews.llvm.org/D56415





More information about the cfe-commits mailing list