[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 5 14:31:28 PST 2019


LegalizeAdulthood marked an inline comment as done.
LegalizeAdulthood added a comment.

In D56323#1347450 <https://reviews.llvm.org/D56323#1347450>, @JonasToth wrote:

> Did you check if the changes actually fix the problematic behaviour? Did you run it over any project and did the code-transformation break the code, false positives, ...?
>
> Otherwise LGTM


The test cases that I added covered the behavior described in the bug report.  I didn't run it over clang to see if it introduced any false positives, I can do that.  However, when I originally wrote this check it was pretty well tested and I have confidence that I haven't regressed. However, it's still worth testing, so I will do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56323/new/

https://reviews.llvm.org/D56323





More information about the cfe-commits mailing list