[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 4 08:48:33 PST 2019


rjmccall added inline comments.


================
Comment at: lib/Driver/ToolChains/HIP.cpp:210
   std::string BundlerTargetArg = "-targets=host-x86_64-unknown-linux";
-  std::string BundlerInputArg = "-inputs=/dev/null";
+  std::string BundlerInputArg = "-inputs=" NULL_FILE;
 
----------------
How hard would it be to just implement the TODO and get away from a reliance on a null file?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56225/new/

https://reviews.llvm.org/D56225





More information about the cfe-commits mailing list