[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

Daniel Dunbar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 3 13:06:56 PST 2019


ddunbar added a comment.

In D56188#1343667 <https://reviews.llvm.org/D56188#1343667>, @rjmccall wrote:

> ...although it might be reasonable to extract the method implementations on `DefaultABIInfo` as helper functions so that the code can be reused without requiring a particular inheritance hierarchy.


I agree that would be cleaner, but don't work on Clang much anymore so was doing the minimal thing. Do you want me to go ahead and do this?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56188/new/

https://reviews.llvm.org/D56188





More information about the cfe-commits mailing list