[PATCH] D56263: [clangd] Always try to build absolute path

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 3 05:45:18 PST 2019


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM
NIT: a typo in the change description: s/smylinks/symlinks

Maybe also add a separate sentence to the description that this should not affect the behavior if file is not a symlink, e.g. something like

  This only changes behavior in cases when the file itself is a symlink.

This information is present in the change description, but a little hard to find.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56263/new/

https://reviews.llvm.org/D56263





More information about the cfe-commits mailing list