[PATCH] D56153: [sanitizer_common] Add test for popen()

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 29 14:49:19 PST 2018


mgorny updated this revision to Diff 179712.
mgorny added a comment.

Added assertion verifying that `fileno(fp)` works.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56153/new/

https://reviews.llvm.org/D56153

Files:
  test/sanitizer_common/TestCases/Posix/popen.cc


Index: test/sanitizer_common/TestCases/Posix/popen.cc
===================================================================
--- /dev/null
+++ test/sanitizer_common/TestCases/Posix/popen.cc
@@ -0,0 +1,23 @@
+// RUN: %clangxx -g %s -o %t && %run %t | FileCheck %s
+// CHECK: 1
+// CHECK-NEXT: 2
+
+#include <assert.h>
+#include <stdio.h>
+
+int main(void) {
+  // use a tool that produces different output than input to verify
+  // that everything worked correctly
+  FILE *fp = popen("sort", "w");
+  assert(fp);
+
+  // verify that fileno() returns a meaningful descriptor (needed
+  // for the implementation of TSan)
+  assert(fileno(fp) != -1);
+
+  assert(fputs("2\n", fp) >= 0);
+  assert(fputs("1\n", fp) >= 0);
+  assert(pclose(fp) == 0);
+
+  return 0;
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56153.179712.patch
Type: text/x-patch
Size: 763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181229/2cccfb43/attachment-0001.bin>


More information about the cfe-commits mailing list