[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

Kamil Rytarowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 28 13:59:00 PST 2018


krytarowski added a subscriber: dvyukov.
krytarowski added a comment.

If we understand it correctly, unpoision FILE would be only for inlined routines accessing FILE buffer(s) directly. On NetBSD we enforce _REENTRANT for all sanitizers in order to support only _REENTRANT variations of calls that go through libc calls.

There is however an exception with `*_unlocked` functions that are still inlined (putc_unlocked(), getc_unlocked(),...) and probably for them we still want to keep SANITIZER_HAS_STRUCT_FILE=1. Such interfaces are niche but still used according to https://codesearch.debian.net/

@vitalybuka @kcc @dvyukov @eugenis

Please help to make it clearer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56109/new/

https://reviews.llvm.org/D56109





More information about the cfe-commits mailing list