[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 28 08:09:37 PST 2018


mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:5698
+#if SANITIZER_NETBSD
+  if (fp->_bf._base)
+    COMMON_INTERCEPTOR_INITIALIZE_RANGE(fp->_bf._base,
----------------
krytarowski wrote:
> maybe `if (fp->_bf._base && fp->_bf._size)`
Ok. I'll even take it further, and since `_size` is signed, check for `> 0`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56109/new/

https://reviews.llvm.org/D56109





More information about the cfe-commits mailing list