[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 20 14:03:53 PST 2018
rsmith added inline comments.
Comment at: lib/Sema/SemaStmt.cpp:2846
> While this looks correct per the current approach to this function, we really shouldn't be duplicating calls to this everywhere. Can we move all the calls to a single call in `ActOnFinishFullStmt`?
Looks like that's not actually called from almost anywhere, but checking from `ActOnFinishFullExpr` in the case where `DiscardedValue` is `true` seems appropriate.
CHANGES SINCE LAST ACTION
More information about the cfe-commits