r349752 - Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

Joerg Sonnenberger via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 20 08:48:01 PST 2018

On Thu, Dec 20, 2018 at 01:09:30PM -0000, Michal Gorny via cfe-commits wrote:
> Author: mgorny
> Date: Thu Dec 20 05:09:30 2018
> New Revision: 349752
> URL: http://llvm.org/viewvc/llvm-project?rev=349752&view=rev
> Log:
> Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]
> Replace multiple comparisons of getOS() value with FreeBSD, NetBSD,
> OpenBSD and DragonFly with matching isOS*BSD() methods.  This should
> improve the consistency of coding style without changing the behavior.
> Direct getOS() comparisons were left whenever used in switch or switch-
> like context.

Personally, I consider this a step backwards and I hugely dislike the
pointless proliferation of isOS* methods.


More information about the cfe-commits mailing list