[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 19 13:53:35 PST 2018


ahatanak added a comment.

In D55662#1335773 <https://reviews.llvm.org/D55662#1335773>, @rjmccall wrote:

> Okay.  You may need to push an unevaluated context when doing that.


Since I'm just moving the call to `CheckPlaceholderExpr` to the call site, I don't think I have to push an unevaluated context there?

Also, it looks like I can just change the check `Init->getType()->isNonOverloadPlaceholderType()`  at the beginning of `Sema::DeduceAutoType` to `Init->getType()->getAsPlaceholderType()` instead of inserting the call to `CheckPlaceholderExpr` right before the call to `BuildDecltypeType`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55662/new/

https://reviews.llvm.org/D55662





More information about the cfe-commits mailing list