[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

So, once upon a time this was a problem because we were rewriting the method calls in the runtime itself.  Can you explain how that's not a problem now?  Do we just expect the runtime to be compiled with the right switch?



================
Comment at: include/clang/Basic/ObjCRuntime.h:191
+  ///   retain => objc_retain
+  ///   release => objc_release
+  bool shouldUseARCFunctionsForRetainRelease() const {
----------------
You're also rewriting `autorelease`.


================
Comment at: include/clang/Basic/ObjCRuntime.h:207
+      case ObjFW:
+        return false;
+    }
----------------
Case indentation.


================
Comment at: lib/CodeGen/CodeGenModule.h:170
+  /// id objc_retain(id);
+  /// Note this is the runtime method not the intrinsic
+  llvm::Constant *objc_retainRuntimeFunction;
----------------
Period (and on the other comments here)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55869/new/

https://reviews.llvm.org/D55869