[PATCH] D55804: [analyzer] C++17: Fix leak false positives when an object with destructor is returned from the top frame.
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 18 15:21:58 PST 2018
NoQ updated this revision to Diff 178802.
NoQ added a comment.
Wait a minute.
In D55804#1334957 <https://reviews.llvm.org/D55804#1334957>, @NoQ wrote:
> we would also need to introduce a separate liveness hack to keep it alive
No, we wouldn't! With a symbolic region it is fine if it dies too early, because putting anything into a symbolic region is an immediate escape anyways. It is still scary to keep it dying too early, but i don't see any actual problem arise from it, and in any case it's better than before, and the leaks do indeed go away.
Additionally, this is still a fairly safe change because there's nothing new in constructing into symbolic regions.
CHANGES SINCE LAST ACTION
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 8846 bytes
Desc: not available
More information about the cfe-commits