[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

Mateusz Maćkowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 18 13:43:33 PST 2018


m4tx marked 6 inline comments as done.
m4tx added inline comments.


================
Comment at: clang-tidy/readability/DuplicatedAccessSpecifiersCheck.cpp:33
+  for (DeclContext::specific_decl_iterator<AccessSpecDecl>
+           NS(MatchedDecl->decls_begin()),
+       NSEnd(MatchedDecl->decls_end());
----------------
aaron.ballman wrote:
> Why `NS` -- that seems like a strange naming choice.
Sorry, this small piece of code was copied from another place and I forgot to change the variable name. I switched to `AS`, hopefully that's more meaningful here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55793/new/

https://reviews.llvm.org/D55793





More information about the cfe-commits mailing list