[PATCH] D55770: [clangd] BackgroundIndex rebuilds symbol index periodically.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 18 06:27:27 PST 2018
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: clangd/index/Background.h:112
+ const size_t BuildIndexPeriodMs;
+ std::atomic<bool> SymbolsUpdatedSinceLastIndex;
+ std::mutex IndexMu;
> We already have a mutex and cv, maybe get rid of this one signal the CV whenever we have an update and sleep for `buildindexperiodms` before issuing the re-build?
`IndexCV` serves two purposes: 1) get notified when `ShouldStop` is set and 2) timeout after `BuildIndexPeriodMs`. We wouldn't want to `sleep` here because it can take too long to shutdown clangd if `BuildIndexPeriodMs` is big.
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
More information about the cfe-commits