[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds
Arnaud Bienner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 18 01:51:27 PST 2018
ArnaudBienner added a comment.
Fixed two tests broken by this change:
- test_diagnostics.py: AFAICT we are not testing all warnings here, but just that warnings are emitted correctly. The "+1" didn't seem to be useful, since the warning triggered was about the const char* being converted to an int (and this warning still applies)
- test/SemaCXX/constant-expression-cxx1y.cpp: is a false positive for -Wstring-plus-int so use the preferred, equivalent syntax
@thakis: do those additional changes look OK to you? Or do you want someone else to review those?
CHANGES SINCE LAST ACTION
More information about the cfe-commits